Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move SupportedFeatures into ClientCapabilitiesFactory #288

Merged
merged 1 commit into from
May 14, 2024

Conversation

angelozerr
Copy link
Contributor

refactor: move SupportedFeatures into ClientCapabilitiesFactory

@angelozerr angelozerr requested a review from fbricon May 13, 2024 18:11
@angelozerr angelozerr added this to the 0.0.1 milestone May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 17.97%. Comparing base (0ad1ea8) to head (428ebc2).

❗ Current head 428ebc2 differs from pull request most recent head 652fff6. Consider uploading reports for the commit 652fff6 to get more accurate results

Files Patch % Lines
...ols/lsp4ij/internal/ClientCapabilitiesFactory.java 0.00% 22 Missing ⚠️
.../redhat/devtools/lsp4ij/LanguageServerWrapper.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   19.27%   17.97%   -1.31%     
==========================================
  Files         239      239              
  Lines        8269     8429     +160     
  Branches     1540     1207     -333     
==========================================
- Hits         1594     1515      -79     
- Misses       6384     6623     +239     
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angelozerr angelozerr force-pushed the supported_features branch from 428ebc2 to 652fff6 Compare May 14, 2024 08:51
@fbricon fbricon merged commit 20883ee into redhat-developer:main May 14, 2024
6 checks passed
@fbricon
Copy link
Contributor

fbricon commented May 14, 2024

thanks @angelozerr

@turkeylurkey
Copy link
Contributor

Thank you @angelozerr

@angelozerr
Copy link
Contributor Author

angelozerr commented May 14, 2024

@turkeylurkey you are welcome!

We would like to create the release soon, so please use our LSP4IJ and report any bugs before the release. Thanks!

@fbricon
Copy link
Contributor

fbricon commented May 14, 2024

@turkeylurkey soon as in next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants