-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AKS Support using spot instances #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianriobo
force-pushed
the
fix-272
branch
2 times, most recently
from
August 9, 2024 07:50
e06aaea
to
eeb8a3a
Compare
adrianriobo
force-pushed
the
fix-272
branch
from
September 17, 2024 10:01
eeb8a3a
to
88948cd
Compare
anjannath
reviewed
Sep 18, 2024
anjannath
reviewed
Sep 18, 2024
anjannath
reviewed
Sep 18, 2024
i think commit log for 88948cd needs to be updated, currently it doesn't say about AKS but adding Ubuntu support:
|
adrianriobo
force-pushed
the
fix-272
branch
from
September 18, 2024 13:31
88948cd
to
de9da38
Compare
@anjannath all done |
adrianriobo
force-pushed
the
fix-272
branch
from
September 19, 2024 08:09
de9da38
to
1d32504
Compare
@adrianriobo PR needs to be rebased again, since the instancetypes PR was merged! |
Signed-off-by: Adrian Riobo <[email protected]>
Signed-off-by: Adrian Riobo <[email protected]>
Signed-off-by: Adrian Riobo <[email protected]>
adrianriobo
force-pushed
the
fix-272
branch
from
September 19, 2024 08:49
1d32504
to
b69d94e
Compare
anjannath
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
Fixes #185