Spot module as a separate package #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjannath
force-pushed
the
spot-module
branch
from
5a4120f
to
1e5fd2e
Compare
anjannath
changed the title
adrianriobo
reviewed
Sep 19, 2024
| return fmt.Errorf("Invalid values for CPUs: %d, Memory: %d and Arch: %s", cpus, memory, arch) | ||
| } | ||
|
|
||
| func (r *AwsInstanceRequest) GetMachineTypes() ([]string, error) { |
There was a problem hiding this comment.
Do you need to rebase and adapt for this?
There was a problem hiding this comment.
it is rebased and ready for review now :)
|
Also same comment as per type of machine applies here, if we rely on this module; is it only SDKs dependent? |
anjannath
force-pushed
the
spot-module
branch
2 times, most recently
from
0fe3039
to
b553996
Compare
yes, this also only depends on the sdks, i've added example on how to use it in: b553996 (not sure we should merge this or not, i am okay to drop it from the PR if needed) |
adrianriobo
reviewed
Sep 24, 2024
|
Also I just merged the defaults so probably this will need rebase again ? |
anjannath
force-pushed
the
spot-module
branch
from
b553996
to
e811c66
Compare
thanks, rebased on main |
adrianriobo
approved these changes
Sep 25, 2024
4 tasks
anjannath
added a commit
to anjannath/mapt
that referenced
this pull request
Sep 27, 2024
this got mistakenly added back during rebase of PR redhat-developer#284 in 42dcadf
lilyLuLiu
pushed a commit
to lilyLuLiu/mapt
that referenced
this pull request
Oct 30, 2024
this got mistakenly added back during rebase of PR redhat-developer#284 in 42dcadf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #277