xml.foldings.includeClosingTagInFold has no effect in binary mode

[newmyl]

My vs code's verion is 1.78.2
Vscode-xml's version is 0.25.0

[angelozerr]

Could you share your xml and provide a sceenshot please

[newmyl]

Could you share your xml and provide a sceenshot please

There is no effect on any xml files. Here is an example file. https://1drv.ms/u/s!Ajrp4wxbM4aWheh2WmQBi4qANSLISg?e=GBKK7E
This is the sceenshot.

[fbricon]

I confirm https://github.com/redhat-developer/vscode-xml/blob/main/docs/Folding.md#xmlfoldingincludeClosingTagInFold no longer works. That's weird given our test suite in LemMinX is pretty exhaustive, it could be something on the vscode side.

[fbricon]

I found that it works when running in JVM mode.

[angelozerr]

I created a PR to fix this issue eclipse-lemminx/lemminx#1523 in binary mode

[newmyl]

I created a PR to fix this issue eclipse/lemminx#1523 in binary mode

Many thanks.

[angelozerr]

@newmyl you can install prerelease https://github.com/redhat-developer/vscode-xml#contributing to benefit with the fix

[newmyl]

@newmyl you can install prerelease https://github.com/redhat-developer/vscode-xml#contributing to benefit with the fix

I have installed the prelelease and it works. Thank you.