Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preference to enable validation #100

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Preference to enable validation #100

merged 1 commit into from
Jan 28, 2019

Conversation

NikolasKomonen
Copy link
Contributor

@NikolasKomonen NikolasKomonen commented Jan 23, 2019 •
edited
Loading

fbricon
fbricon reviewed Jan 23, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@fbricon fbricon added this to the 0.3.0 milestone Jan 23, 2019
fbricon
fbricon reviewed Jan 23, 2019
View reviewed changes
package.json Show resolved Hide resolved
@NikolasKomonen NikolasKomonen force-pushed the validationJSON branch 2 times, most recently from 6335fa7 to a7ee844 Compare January 25, 2019 19:54
@NikolasKomonen
Copy link
Contributor Author

@fbricon updated with diagnostics -> validation

fbricon
fbricon approved these changes Jan 28, 2019
View reviewed changes
Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge once the server side PR is merged

@NikolasKomonen NikolasKomonen merged commit 6180853 into redhat-developer:master Jan 28, 2019
@NikolasKomonen NikolasKomonen deleted the validationJSON branch March 7, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasKomonen @fbricon