Contribute to completion, hover .. with external JAR

[angelozerr]

Contribute to completion, hover .. with external JAR

Fixes #190

Signed-off-by: azerr [email protected]

[angelozerr]

This PR gives the capability to contribute with custom completion, hover, etc by using SPI mechanism used by LSP4XML by developping a vscode extension which declares in the package.json, the xml.javaExtensions:

       "contributes": {
		"xml.javaExtensions": [
			"./jar/org.eclipse.lsp4xml.extensions.maven-0.9.1.jar"
		]
	}

See a sample at https://github.com/angelozerr/vscode-xml-maven/blob/master/package.json#L18

Please review the code for the moment and I will explain you soon how to test it.

[angelozerr]

To test this PR you can do it with https://github.com/angelozerr/vscode-xml-maven/blob/master/package.json#L18

This vscode extension extends the completion scope for maven by using LSP5XML SPI completion participant for maven. See https://github.com/angelozerr/lsp4xml-extensions-maven/blob/master/org.eclipse.lsp4xml.extensions.maven/src/main/java/org/eclipse/lsp4xml/extensions/maven/MavenCompletionParticipant.java#L39

As we cannot launch 2 extensions in vscode, you should

• install [vscode-xml-maven-0.0.1.vsix)(vscode-xml-maven with https://github.com/angelozerr/vscode-xml-maven/blob/master/vscode-xml-maven-0.0.1.vsix)
• launch vscode-xml with this PR
• open a pom.xml file and open the completion inside scope element, you should have that:

[xorye]

the completion is working for me

[angelozerr]

the completion is working for me

Are you testing in Linux OS? If your test in Linux OS, it's very cool because it means classpath build is working on any OS (I'm on Windows OS). See https://github.com/redhat-developer/vscode-xml/pull/193/files#diff-d106f0e1914f2f6cbf79404a7f0c42b4R43

@xorye please tell me if you need some other changes, otherwise please merge it, thanks!

[xorye]

Yes, I am testing on Linux OS, and pathSeparator is : for me, so that's good.

[xorye]

vscode-xml/package.json

Line 19 in 3d321fe

"vscode": "^1.27.0"

Could you change this to "^1.37.0", so that its "vscode": "^1.37.0"?
Since we are using @types/vscode 1.37.0, we need that to change.

[angelozerr]

Could you change this to "^1.37.0", so that its "vscode": "^1.37.0"?

@xorye fixed.

[xorye]

Looks good!