Use the extension version in download URL for binary. #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The language server version was used as the version for the download URL of the binary, but since the binaries are hosted under the vscode-xml release tab, it should match the vscode-xml release - Remove some unnecessary steps from the release job Signed-off-by: Roland Grunberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also slightly refactored the ordering. The preparing of the pre-release affects the final version number, so extracting the version number must happen after. Any workflow that users the versions can occur immediately after.
Also set xmlServer/version back to 0.28.0 as we may end up doing a bug fix release for this, using the same language server.