Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-66582) feat(dracut.sh): add --add-confdir option #100

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Nov 27, 2024

When generating kdump's initrd, we want to keep [omit_]dracutmodules
empty and let kdump to handle the modules. And we don't want to
affect the first kernel's initrd, so we cannot place our conf file
to /etc/dracut.conf.d or /usr/lib/dracut/dracut.conf.d.

This patch adds a new option to allow user to add an extra configuration
directory to use *.conf files from. If the dir not exists, will look for
confdir's subdir.

After that, kdump can use "--add-confdir kdump" if
/usr/lib/dracut/dracut.conf.d/kdump exists, to apply its own dracut conf.

See also:
rhkdump/kdump-utils#11
rhkdump/kdump-utils#31

Suggested-by: Dave Young [email protected]
Signed-off-by: Lichen Liu [email protected]

(cherry picked from commit ae81535037c42b716d8cbb9dc18942b5c6f16fed)

Resolves: RHEL-66582

When generating kdump's initrd, we want to keep [omit_]dracutmodules
empty and let kdump to handle the modules. And we don't want to
affect the first kernel's initrd, so we cannot place our conf file
to /etc/dracut.conf.d or /usr/lib/dracut/dracut.conf.d.

This patch adds a new option to allow user to add an extra configuration
directory to use *.conf files from. If the dir not exists, will look for
confdir's subdir.

After that, kdump can use "--add-confdir kdump" if
/usr/lib/dracut/dracut.conf.d/kdump exists, to apply its own dracut conf.

See also:
rhkdump/kdump-utils#11
rhkdump/kdump-utils#31

Suggested-by: Dave Young <[email protected]>
Signed-off-by: Lichen Liu <[email protected]>

(cherry picked from commit ae81535037c42b716d8cbb9dc18942b5c6f16fed)

Resolves: RHEL-66582
@pvalena pvalena added the bug Something isn't working label Nov 27, 2024
@pvalena pvalena self-assigned this Nov 27, 2024
(cherry picked from commit 76b2f1a9b52afd4203c1d0e6afb57314bbfe8407)

Resolves: RHEL-66582
@github-actions github-actions bot changed the title feat(dracut.sh): add --add-confdir option (RHEL-66582) feat(dracut.sh): add --add-confdir option Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Commit validation

Tracker - RHEL-66582

The following commits meet all requirements

commit upstream
3412ef4 - fix: typo in variable name dracutdevs/dracut@76b2f1a

The following commits need an inspection

commit note
48b323e - feat(dracut.sh): add --add-confdir option Missing upstream reference ‼️

Tracker validation

Success

🟢 Tracker RHEL-66582 has set desired product: rhel-9.6
🟢 Tracker RHEL-66582 has set desired component: dracut
🟢 Tracker RHEL-66582 has been approved
🟢 Tracker RHEL-66582 has set severity


Pull Request validation

Failed

🔴 Failed or pending checks - test (centos:stream9, 35)[failure],test (centos:stream9, 36)[failure],test (centos:stream9, 31)[failure],test (centos:stream9, 30)[failure],test (centos:stream9, 14)[failure],test (centos:stream9, 15)[failure],test (centos:stream9, 03)[failure],centos-9-stream (centos:stream9, 98)[cancelled],centos-9-stream (centos:stream9, 41)[cancelled],centos-9-stream (centos:stream9, 40)[cancelled],centos-9-stream (centos:stream9, 21)[cancelled],centos-9-stream (centos:stream9, 17)[cancelled],centos-9-stream (centos:stream9, 20)[cancelled],centos-9-stream (centos:stream9, 16)[cancelled],centos-9-stream (centos:stream9, 12)[cancelled],centos-9-stream (centos:stream9, 13)[cancelled],centos-9-stream (centos:stream9, 11)[cancelled],centos-9-stream (centos:stream9, 02)[cancelled],centos-9-stream (centos:stream9, 10)[cancelled],centos-9-stream (centos:stream9, 01)[cancelled],basic (centos:stream9, 04)[failure],testing-farm:centos-stream-9-x86_64[in_progress],rpm-build:centos-stream-9-aarch64[in_progress],rpm-build:centos-stream-9-x86_64[in_progress],test (centos:stream9, 21)[in_progress],test (centos:stream9, 20)[in_progress],test (centos:stream9, 17)[in_progress],test (centos:stream9, 16)[in_progress],test (centos:stream9, 13)[in_progress],test (centos:stream9, 12)[in_progress],test (centos:stream9, 11)[in_progress],test (centos:stream9, 10)[in_progress],test (centos:stream9, 01)[in_progress],lint-shell[in_progress]
🔴 Review - Missing review from a member (1 required)

@pvalena
Copy link
Contributor Author

pvalena commented Nov 27, 2024

LGTM.

@pvalena pvalena merged commit cb1c0c9 into redhat-plumbers:main Nov 27, 2024
21 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants