Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the renaming of certsuite config file and some flags #421

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix for the renaming of certsuite config file and some flags #421

merged 1 commit into from
Sep 5, 2024

Conversation

ramperher
Copy link
Contributor

@ramperher ramperher commented Sep 4, 2024 •
edited
Loading

SUMMARY

This change in certsuite introduced a couple of new features that needs to be included also in k8s_best_practices_certsuite role:

  • Renaming of config file
  • Renaming of some flags
ISSUE TYPE
  • New or Enhanced Feature
Tests

Test-Hints: no-check

@ramperher ramperher requested a review from a team as a code owner September 4, 2024 21:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/0a06037956154c4487f0cb7d484f5b57

✔️ dci-rpm-build-el8 SUCCESS in 2m 42s
✔️ dci-rpm-build-el9 SUCCESS in 2m 26s

@ramperher ramperher mentioned this pull request Sep 4, 2024
Merged
@dcibot
Copy link
Collaborator

dcibot commented Sep 4, 2024

from change #421:

@ramperher
Copy link
Contributor Author

from change #421:

This is working but I forgot to add some more checks in the teardown, running a couple of more tests

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/17388148e3f342ccad186c28bbf685c6

✔️ dci-rpm-build-el8 SUCCESS in 2m 42s
✔️ dci-rpm-build-el9 SUCCESS in 2m 18s

@dcibot
Copy link
Collaborator

dcibot commented Sep 4, 2024

from change #421:

tonyskapunk
tonyskapunk reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch for this!

While the patch works for the current state I'm unsure about it once there's a new release, and I wonder if we should wait or at least reconsider it.

roles/k8s_best_practices_certsuite/defaults/main.yml Outdated Show resolved Hide resolved
roles/k8s_best_practices_certsuite/tasks/teardown.yml Outdated Show resolved Hide resolved
roles/k8s_best_practices_certsuite/tasks/teardown.yml Outdated Show resolved Hide resolved
@dcibot
Copy link
Collaborator

dcibot commented Sep 4, 2024

from change #421:

@ramperher
Copy link
Contributor Author

Testing is finished, so just waiting for reviews.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/48aa9ba02ac64e04aae428e00c1bf191

✔️ dci-rpm-build-el8 SUCCESS in 2m 43s
✔️ dci-rpm-build-el9 SUCCESS in 2m 24s

@dcibot
Copy link
Collaborator

dcibot commented Sep 4, 2024

from change #421:

This was referenced Sep 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2397:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2398:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2389:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2303:

@ramperher ramperher mentioned this pull request Sep 5, 2024
Merged
@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2400:

sebrandon1
sebrandon1 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about the changing debug to probe.

roles/k8s_best_practices_certsuite/tasks/teardown.yml Outdated Show resolved Hide resolved
roles/k8s_best_practices_certsuite/tasks/teardown.yml Outdated Show resolved Hide resolved
roles/k8s_best_practices_certsuite/tasks/teardown.yml Outdated Show resolved Hide resolved
@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2393:

@ramperher
Copy link
Contributor Author

from change redhat-best-practices-for-k8s/certsuite#2393:

This failure is not related to this change, it's related to redhat-best-practices-for-k8s/certsuite#2393

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change #421:

  • no check (not a code change)

@sebrandon1
Copy link
Contributor

@ramperher Seems there's maybe a docker error on the host building the image?

time=\"2024-09-05T08:00:14-05:00\" level=error msg=\"unable to cleanup run mounts error in copier subprocess: changing to intended-new-root directory \\\"/home/dciteam/.local/share/containers/storage/overlay/1f39cf74a60dafec508bedef08141f2d984b4777efd2f8e569f70649d256a86a/merged\\\": chdir /home/dciteam/.local/share/containers/storage/overlay/1f39cf74a60dafec508bedef08141f2d984b4777efd2f8e569f70649d256a86a/merged: no such file or directory\"
time=\"2024-09-05T08:00:14-05:00\" level=error msg=\"error unmounting container: unmounting build container \\\"429b36269b964937dcfadde194e45f61fd1be9db2a31561804c5d0fe5dbc80d8\\\": layer not known\"
time=\"2024-09-05T08:00:14-05:00\" level=error msg=\"error deleting build container \\\"a1aeebab8deceb004d1c63c90bd160c6bdd5a167cf55eddbab729d7635f36ebe\\\": identifier is not a container\

@ramperher
Copy link
Contributor Author

@ramperher Seems there's maybe a docker error on the host building the image?

time=\"2024-09-05T08:00:14-05:00\" level=error msg=\"unable to cleanup run mounts error in copier subprocess: changing to intended-new-root directory \\\"/home/dciteam/.local/share/containers/storage/overlay/1f39cf74a60dafec508bedef08141f2d984b4777efd2f8e569f70649d256a86a/merged\\\": chdir /home/dciteam/.local/share/containers/storage/overlay/1f39cf74a60dafec508bedef08141f2d984b4777efd2f8e569f70649d256a86a/merged: no such file or directory\"
time=\"2024-09-05T08:00:14-05:00\" level=error msg=\"error unmounting container: unmounting build container \\\"429b36269b964937dcfadde194e45f61fd1be9db2a31561804c5d0fe5dbc80d8\\\": layer not known\"
time=\"2024-09-05T08:00:14-05:00\" level=error msg=\"error deleting build container \\\"a1aeebab8deceb004d1c63c90bd160c6bdd5a167cf55eddbab729d7635f36ebe\\\": identifier is not a container\

I'm not really worried about that issue because it happens from time to time that the "bump XX" PRs in certsuite repo fail sometimes when building the image, so maybe it's an isolated case

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2397:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/cb0279ebceb04d629efa4acac8af161a

✔️ dci-rpm-build-el8 SUCCESS in 2m 51s
✔️ dci-rpm-build-el9 SUCCESS in 2m 25s

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2396:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2394:

  • ERROR no DCI job found

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2395:

  • ERROR no DCI job found

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2398:

tonyskapunk
tonyskapunk approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyskapunk
Copy link
Contributor

retest

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change #421:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change #421:

  • no check (not a code change)

@tonyskapunk tonyskapunk added this pull request to the merge queue Sep 5, 2024
@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2393:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2394:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2395:

Merged via the queue into main with commit e041f0b Sep 5, 2024
6 of 7 checks passed
@tonyskapunk tonyskapunk deleted the certsuite-new-flags branch September 5, 2024 17:29
@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2400:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2398:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2397:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2393:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2394:

@dcibot
Copy link
Collaborator

dcibot commented Sep 5, 2024

from change redhat-best-practices-for-k8s/certsuite#2395:

@dcibot
Copy link
Collaborator

dcibot commented Sep 6, 2024

from change redhat-best-practices-for-k8s/certsuite#2303:

@dcibot
Copy link
Collaborator

dcibot commented Sep 6, 2024

from change redhat-best-practices-for-k8s/certsuite#2303:

@dcibot
Copy link
Collaborator

dcibot commented Sep 12, 2024

from change redhat-best-practices-for-k8s/certsuite#2389:

@dcibot
Copy link
Collaborator

dcibot commented Sep 12, 2024

from change redhat-best-practices-for-k8s/certsuite#2389:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrandon1 sebrandon1 sebrandon1 left review comments

@tonyskapunk tonyskapunk tonyskapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramperher @dcibot @sebrandon1 @tonyskapunk