Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap provider #166

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
8841350
base implementation
metallkopf Nov 24, 2024
f28ee27
add defaults
metallkopf Nov 24, 2024
3c8e496
simple tests
metallkopf Nov 29, 2024
9e53b1a
feat: added openldap to -slim image
redimp Dec 1, 2024
3c8ff78
fixup
redimp Dec 1, 2024
55ecec7
wip: added debug output
redimp Dec 1, 2024
6804d68
added example to test ldap
redimp Dec 1, 2024
b322c65
patch ldap docker
metallkopf Dec 2, 2024
67d0a82
auth_examples/ldap: fixed SECRET_KEY for easier testing
redimp Dec 5, 2024
5ec93a3
fix: user add/edit stores the provider in the database
redimp Dec 5, 2024
34d6769
auto register ldap users on login
metallkopf Dec 6, 2024
8118ed3
auto register test
metallkopf Dec 6, 2024
2f96664
chore: make sure tox installs the dev environment (to get fakeldap)
redimp Dec 8, 2024
615c511
docs: added README to ldap-auth exmaple, enabled register on login
redimp Dec 8, 2024
62e8f0d
docu: Update helm readme to use right helm repository URL
Dec 20, 2024
aaa4ab1
feat: added option to add line numbers to code blocks
redimp Jan 11, 2025
11d3b5b
chore(deps): bump jinja2 from 3.1.4 to 3.1.5
dependabot[bot] Jan 8, 2025
cb4cab4
feat: added database migration
redimp Jan 12, 2025
37fc2cd
added mtime(filename): return modification datetime of file
redimp Jan 18, 2025
4bac818
added Cache to models
redimp Jan 18, 2025
923a0b1
chore: ignore settings with wildcards
redimp Jan 18, 2025
98980cc
fix: word-break n the sidebar optimized. Do not break the ::before el…
redimp Jan 18, 2025
634cec8
test: added some tests to the wiki link compatibility mode
redimp Jan 19, 2025
f596585
chore: reworked parse_wikilink
redimp Jan 19, 2025
89448e4
chore(deps): updated mermaidjs to 11.4.1
redimp Jan 19, 2025
44f8bf3
feat: added some responsiveness to the sidebar
redimp Jan 19, 2025
ffecd35
base implementation
metallkopf Nov 24, 2024
54b475c
feat: added database migration
redimp Jan 12, 2025
9645271
fixup: merge error
redimp Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions otterwiki/preferences.py
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ def handle_user_add(form):
# update user from form
user.name = form.get("name").strip() # pyright: ignore
user.email = form.get("email").strip() # pyright: ignore
user.provider = form.get("provider").strip() # pyright: ignore
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this addition was producing an error on my end

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste tested this on the resent commit 615c511 adding a User works as expected. Can ypu please try to reproduce the error?


for value, _ in [
("email_confirmed", "email confirmed"),
Expand Down Expand Up @@ -505,6 +506,9 @@ def handle_user_edit(uid, form):
else:
user.password_hash = generate_password_hash(form.get("password1"))
msgs.append("Updated password")
if user.provider != form.get("provider","local"):
user.provider = form.get("provider","local").strip() # pyright: ignore
msgs.append("Updated provider")
user_was_already_approved = user.is_approved
# handle all the flags
for value, label in [
Expand Down