Skip to content

Commit

Permalink
Extensive unit tests for PipeliningBase (#3778)
Browse files Browse the repository at this point in the history
* Extensive unit tests for PipeliningBase

Add extensive unit tests for the PipeliningBase abstract class. Since
this class holds a lot of functionality for its subclasses, it makes
sense to test it in isolation. And since the functionality is very
repetitive, it makes sense to use mocking. Basically this abstract class
just shuffles commands around from a CommandObjects to its subclasses,
and this can be covered very well with mocked tests.

* Fix flaky test

A slow log test seems to sometimes get a duration of zero for an
operation. Cover this case too in the assertion.

---------

Co-authored-by: Gabriel Erzse <[email protected]>
  • Loading branch information
gerzse and gerzse authored Mar 19, 2024
1 parent 56ef26a commit 812a291
Show file tree
Hide file tree
Showing 2 changed files with 10,503 additions and 1 deletion.
Loading

0 comments on commit 812a291

Please sign in to comment.