Allow exclusion of GSON dependency #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move creation of the GSON instance to a separate class which is initialised only when any of the json methods are being used. This allows GSON and org.json transitive Maven dependencies to be excluded for the applications which don't use json methods.
sazzad16
requested changes
Dec 7, 2022
Codecov ReportBase: 66.96% // Head: 66.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3223 +/- ##
============================================
- Coverage 66.96% 66.93% -0.03%
- Complexity 4606 4611 +5
============================================
Files 251 253 +2
Lines 14864 14884 +20
Branches 922 923 +1
============================================
+ Hits 9953 9962 +9
- Misses 4511 4524 +13
+ Partials 400 398 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
agavrilov76
changed the title
Done. The title and description are updated |
chayim
approved these changes
Dec 13, 2022
sazzad16
approved these changes
Dec 13, 2022
agavrilov76
added a commit
to agavrilov76/jedis
that referenced
this pull request
Dec 16, 2022
Move creation of the JSON command builders to a separate class which is initialized only when any of the JSON methods are being used. This allows org.json transitive Maven dependency to be excluded for the applications which don't use JSON methods. See redis#2961 and redis#2962 for more information and rationale. Similar to redis#3223
sazzad16
pushed a commit
that referenced
this pull request
Jan 11, 2023
Move creation of the JSON command builders to a separate class which is initialized only when any of the JSON methods are being used. This allows org.json transitive Maven dependency to be excluded for the applications which don't use JSON methods. See #2961 and #2962 for more information and rationale. Similar to #3223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move creation of the GSON instance to a separate class which is initialized only when any of the JSON methods are being used. This allows
gsontransitive Maven dependency to be excluded for the applications which don't use JSON methods.See #2961 and #2962 for more information and rationale