Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Java code snippets for sets redis#3626 #3661

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

suraj11chauhan
Copy link
Contributor

I have added the Java code example for the 'set' operation in the 'io.redis.examples' package. Please review my code! set_tutorial#3626 @sav-norem

Copy link
Contributor

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-submitting, Suraj.

The code is missing a couple of STEP_END lines, which breaks the doc build. Please correct per the comments below.

@suraj11chauhan
Copy link
Contributor Author

I have added '// STEP_END' lines to the code. Thank you!! @dwdougherty

Copy link
Contributor

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Docs build correctly.

@sazzad16 sazzad16 merged commit cea57ff into redis:emb-examples Jan 2, 2024
1 check passed
@suraj11chauhan suraj11chauhan deleted the set_tutorial#3626 branch January 5, 2024 20:44
@suraj11chauhan suraj11chauhan restored the set_tutorial#3626 branch January 5, 2024 20:45
uglide added a commit that referenced this pull request Jun 18, 2024
* Fix search_quickstart example

* Add data_class step to SearchQuickstartExample

* Update examples with new bikes and align to new tutorial

* Fixes doctests for search tutorial

* Small fixes doctests

* Updates search tutorial doc examples to new format and data

* Fix formatting in doc tests

* Add Hashes and String Example (#3477)

* Add Hashes Example

* Fixes examples for hash tutorial

* Refactor Hash Tutorial to Java 8 (from 17)

* Change indentation to 4 spaces

* Add Strings Example

* Reformat samples to 2-space indentation

---------

Co-authored-by: Elena Kolevska <[email protected]>

* Add Geospatial data type example (#3487)

* Add Geospatial data type example

* Add missing REMOVE_END

* Added example Java code snippets for Streams (#3641)

* Java example code snippets for T-Digest and TopK (#3660)

* Created example for t digest

* Added example for topK

---------

Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: Ranjeet Singh <[email protected]>

* Create Java code snippets for sets #3626 (#3661)

* Create Java code snippets for sets #3626

* Apply suggestions from code review to add // STEP_END lines.

Co-authored-by: David Dougherty <[email protected]>

* format imports

---------

Co-authored-by: David Dougherty <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>

* Create Java code snippets for count min sketch (#3644)

* added code snippet for CMS in Java

* Update CMSExample.java

* format spaces

* use cmsIncrBy simple variant

* more format spaces

---------

Co-authored-by: M Sazzadul Hoque <[email protected]>

* Added Java code snippets for Bloom #3630  (#3671)

* Added java example for bloom filter

* Removed space

* fix and format imports

* fix compile error

* format spaces

* Add del command and rename obj

* Add del command and fix format

* change to junit assert

* Update BloomFilterExample.java

* Add correct output comment

---------

Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
Co-authored-by: Ranjeet Singh <[email protected]>

* Added java code snippet for hyperloglog (#3674)

* Added Java code snippet for HyperLogLog

* fix format and imports

* fix spaces

* change to junit assert

* Added correct output comment

* Update HyperLogLogExample.java

---------

Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>

* Added Java code snippets for cuckoo filters (#3679)

* Add CuckooFilterExample

* Add step start comment

* Update CuckooFilterExample.java

---------

Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>

* Create Java code snippet for lists #3625 (#3677)

* Added example Java code snippets for the List#3625

* format spaces

---------

Co-authored-by: M Sazzadul Hoque <[email protected]>

* Create Java code snippet for sorted sets  (#3680)

* added an example for SortedSets in java

* Update SortedSetsExample.java

* made changes as per the review.

* Format spaces in SortedSetsExample.java

---------

Co-authored-by: M Sazzadul Hoque <[email protected]>

* Added Java code snippet for bitmap  (#3687)

* Add bitmap example

* Change class name

* Add assert for res3 and res4

* Update BitMapsExample.java

* Format spaces in BitMapsExample.java

---------

Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>

---------

Co-authored-by: Elena Kolevska <[email protected]>
Co-authored-by: Brian Sam-Bodden <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
Co-authored-by: Harshvardhan Parmar <[email protected]>
Co-authored-by: Ranjeet SIngh <[email protected]>
Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: Ranjeet Singh <[email protected]>
Co-authored-by: Suraj <[email protected]>
Co-authored-by: David Dougherty <[email protected]>
Co-authored-by: Ranjeet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants