Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TTL in client side caching #3695

Closed
wants to merge 3 commits into from
Closed

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jan 24, 2024

using third-party libraries:

  • Caffeine
  • Guava cache

Currently superseded by #3698

@sazzad16 sazzad16 changed the title Support TTL in client side caching (using Caffeine library) Support TTL in client side caching Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (3ab6bdc) 75.64% compared to head (b7ec9fa) 75.54%.

❗ Current head b7ec9fa differs from pull request most recent head 2ef4376. Consider uploading reports for the commit 2ef4376 to get more accurate results

Files Patch % Lines
...ain/java/redis/clients/jedis/util/CaffeineCSC.java 0.00% 16 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.2.0    #3695      +/-   ##
============================================
- Coverage     75.64%   75.54%   -0.11%     
+ Complexity     4962     4960       -2     
============================================
  Files           298      299       +1     
  Lines         15113    15120       +7     
  Branches       1138     1138              
============================================
- Hits          11432    11422      -10     
- Misses         3178     3195      +17     
  Partials        503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim requested a review from gerzse January 28, 2024 10:41
@sazzad16 sazzad16 marked this pull request as draft January 28, 2024 10:50
@sazzad16 sazzad16 closed this Feb 15, 2024
@sazzad16 sazzad16 deleted the caffeine branch February 15, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants