Fix NPE in empty XPENDING summary #3792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no pending messages in a stream, the summary response to XPENDING contains nulls, except the first position which is 0 (the total number of pending message). Return early from the builder, in this case, to avoid NPE.
sazzad16
reviewed
Mar 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3792 +/- ##
============================================
- Coverage 79.50% 79.45% -0.05%
Complexity 5695 5695
============================================
Files 301 301
Lines 15274 15276 +2
Branches 1190 1191 +1
============================================
- Hits 12143 12138 -5
- Misses 2554 2559 +5
- Partials 577 579 +2 ☔ View full report in Codecov by Sentry. |
I have it in a big PR only with unit tests. It would be some effort to retrofit it. Would it be ok to merge this separately, and the test later? |
sazzad16
reviewed
Mar 28, 2024
| @@ -1813,6 +1813,11 @@ public StreamPendingSummary build(Object data) { | |||
|
|
|||
| List<Object> objectList = (List<Object>) data; | |||
| long total = BuilderFactory.LONG.build(objectList.get(0)); | |||
|
|
|||
| if (total == 0) { | |||
| return new StreamPendingSummary(total, null, null, null); | |||
There was a problem hiding this comment.
We just don't return null on our own.
We return null or whatever only after reading it.
|
Fixed more properly in 7393. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no pending messages in a stream, the summary response to XPENDING contains nulls, except the first position which is 0 (the total number of pending message). Return early from the builder, in this case, to avoid NPE.