Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test modules CONFIG support #4043

Merged
merged 12 commits into from
Jan 30, 2025
Prev Previous commit
Next Next commit
Based on RedisModuleCommandsTestBase
sazzad16 committed Jan 29, 2025
commit 598c66cb9804d408e498b0e2acb44388f5fb66ee
Original file line number Diff line number Diff line change
@@ -15,11 +15,9 @@
public abstract class JedisCommandsTestBase {

@Rule
public RedisVersionRule versionRule = new RedisVersionRule(
HostAndPorts.getRedisEndpoint("standalone0"));
public RedisVersionRule versionRule = new RedisVersionRule(endpoint);
@Rule
public EnabledOnCommandRule enabledOnCommandRule = new EnabledOnCommandRule(
HostAndPorts.getRedisEndpoint("standalone0"));
public EnabledOnCommandRule enabledOnCommandRule = new EnabledOnCommandRule(endpoint);

/**
* Input data for parameterized tests. In principle all subclasses of this
Original file line number Diff line number Diff line change
@@ -12,12 +12,11 @@
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import redis.clients.jedis.RedisProtocol;
import redis.clients.jedis.commands.jedis.JedisCommandsTestBase;
import redis.clients.jedis.exceptions.JedisDataException;

@SinceRedisVersion(value = "7.9.0")
@RunWith(Parameterized.class)
public class ConsolidatedConfigurationCommandsTest extends JedisCommandsTestBase {
public class ConsolidatedConfigurationCommandsTest extends RedisModuleCommandsTestBase {

public ConsolidatedConfigurationCommandsTest(RedisProtocol redisProtocol) {
super(redisProtocol);
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
public abstract class RedisModuleCommandsTestBase {

@Rule
public RedisVersionRule versionRule = new RedisVersionRule(hnp,DefaultJedisClientConfig.builder().build() );
public RedisVersionRule versionRule = new RedisVersionRule(hnp, DefaultJedisClientConfig.builder().build());

/**
* Input data for parameterized tests. In principle all subclasses of this
@@ -39,6 +39,7 @@ public static Collection<Object[]> data() {
protected static final HostAndPort hnp = HostAndPort.from(address);
protected final RedisProtocol protocol;

protected Jedis jedis;
protected UnifiedJedis client;

/**
@@ -65,9 +66,8 @@ public static void prepare() {

@Before
public void setUp() {
try (Jedis jedis = new Jedis(hnp)) {
jedis.flushAll();
}
jedis = new Jedis(hnp, DefaultJedisClientConfig.builder().protocol(protocol).build());
jedis.flushAll();
client = new UnifiedJedis(hnp, DefaultJedisClientConfig.builder().protocol(protocol).build());
}