Test with 8.0-M04-pre #4069
Open
Test with 8.0-M04-pre #4069
+153
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of ft.explain has changed in Redis 8.0. Existing Jedis client ftExplain() API returns the raw output and does not perform any parsing/mapping, hence updating the test to verify only for received output when used with correct dialect & gets syntax error otherwise.
sazzad16
requested changes
Jan 29, 2025
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertThrows; | ||
| import static org.junit.Assert.assertTrue; |
There was a problem hiding this comment.
Replace remaining assertTrues with proper assertThats.
Suggested change
| import static org.junit.Assert.assertTrue; |
There was a problem hiding this comment.
I have replaced the remaining ones in the concrete test.
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Outdated
Show resolved
Hide resolved
… module replacing default SCORER from TF-IDF to BM25.
Co-authored-by: M Sazzadul Hoque <[email protected]>
sazzad16
requested changes
Jan 29, 2025
sazzad16
reviewed
Jan 29, 2025
src/test/java/redis/clients/jedis/modules/search/SearchDefaultDialectTest.java
Show resolved
Hide resolved
Existing Jedis client ftExplain() API returns the raw output and does not perform any parsing/mapping, hence updating the test to verify only for received output when used with correct dialect & gets syntax error otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.