Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the NOVALUES option of HSCAN #2711

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Feb 27, 2024

Description

Issue #2705

The NOVALUES option instructs HSCAN to only return keys, without their values.
The new option will become available from Redis 7.6.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@gerzse gerzse requested a review from leibale February 27, 2024 08:07
@leibale
Copy link
Collaborator

leibale commented Feb 27, 2024

@gerzse arguments that change the reply type should be implemented as their own command, see HRANDFIELD_COUNT and HRANDFIELD_COUNT_WITHVALUES for example.

For this command, we should have:

  1. HSCAN/hScan
  2. HSCAN_NOVALUES/hScanNoValues
  3. hScanIterator
  4. hScanNoValuesIterator

@gerzse
Copy link
Contributor Author

gerzse commented Mar 4, 2024

@gerzse arguments that change the reply type should be implemented as their own command, see HRANDFIELD_COUNT and HRANDFIELD_COUNT_WITHVALUES for example.

For this command, we should have:

  1. HSCAN/hScan
  2. HSCAN_NOVALUES/hScanNoValues
  3. hScanIterator
  4. hScanNoValuesIterator

@leibale Got it, thanks! Makes sense, the same is done in other clients too. I'll adapt the code.

@gerzse gerzse force-pushed the hscan-no-values branch from 58d419c to 49d3861 Compare March 4, 2024 09:27
Issue redis#2705

The NOVALUES option instructs HSCAN to only return keys, without their
values. This is materialized as a new command, `hScanNoValues`, given
that the return type is different from the usual return type of `hScan`.
Also a new iterator is provided, `hScanNoValuesIterator`, for the same
reason.
@gerzse gerzse force-pushed the hscan-no-values branch from 49d3861 to e3263c6 Compare March 4, 2024 09:33
@leibale leibale mentioned this pull request May 16, 2024
3 tasks
@leibale leibale mentioned this pull request Jun 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants