add queue_class to REDIS_ALLOWED_KEYS (#2577)

* add queue_class to REDIS_ALLOWED_KEYS * fix lint * fix lint --------- Co-authored-by: zach.lee <[email protected]> Co-authored-by: dvora-h <[email protected]>
redis · Mar 16, 2023 · d63313b · d63313b
1 parent c61eeb2
commit d63313b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/redis/cluster.py b/redis/cluster.py
@@ -135,6 +135,7 @@ def parse_cluster_shards(resp, **options):
     "redis_connect_func",
     "password",
     "port",
+    "queue_class",
     "retry",
     "retry_on_timeout",
     "socket_connect_timeout",

diff --git a/tests/test_cluster.py b/tests/test_cluster.py
@@ -1,6 +1,7 @@
 import binascii
 import datetime
 import warnings
+from queue import LifoQueue, Queue
 from time import sleep
 from unittest.mock import DEFAULT, Mock, call, patch
 
@@ -2511,6 +2512,18 @@ def test_connection_pool_class(self, connection_pool_class):
                 node.redis_connection.connection_pool, connection_pool_class
             )
 
+    @pytest.mark.parametrize("queue_class", [Queue, LifoQueue])
+    def test_allow_custom_queue_class(self, queue_class):
+        rc = get_mocked_redis_client(
+            url="redis://[email protected]:7000",
+            cluster_slots=default_cluster_slots,
+            connection_pool_class=BlockingConnectionPool,
+            queue_class=queue_class,
+        )
+
+        for node in rc.nodes_manager.nodes_cache.values():
+            assert node.redis_connection.connection_pool.queue_class == queue_class
+
 
 @pytest.mark.onlycluster
 class TestClusterPubSubObject: