Add rack_id field for Kafka components #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560.
I managed to run the
TestIntegration/kafka_redpandaandTestIntegration/kafka_oldintegration tests in a DinD container, sincekafka_oldrequires the correct host IP which doesn't work directly on Docker for Mac. There doesn't seem to be any easy way to add a specific test for this field, so I guess we'll just have to count on Sarama to do the right thing.Annoyingly, since
ListNetworksdoesn't work correctly in DinD, I hardcoded the "host" IP address in the code to run thekafka_oldtests. There's a bug report for this since 2016 🤦♂️