Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timesheet and worklogs to employee-specific graph #4

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

x-m-el
Copy link
Collaborator

@x-m-el x-m-el commented Dec 23, 2024

A group public-all-employees is used so kimai-service can keep access to all the graphs.

add a group `public-all-employees` so kimai-service kan keep access to all the graphs.
only persons part of the `employee` group have their own graph. The assumption is made that other users have no timesheet/worklog data.
@madnificent
Copy link
Member

Looking at this from a distance, I think this will work as long as we don't have too many users (sadly, I don't know the number where it will fail). Some naming improvements may help a first read.

As the amount of graphs grows, we'll select from more of them which makes the triplestore slow. Further, having too many mu-auth-allowed-groups could make the header too long. An ideal solution would collect the data from the users and populate a graph for Kimai to consume. We should be prepared to quickly use sudo-queries instead when the problem would appear. Looking at the sync service that should be feasible on late notice so that's ok for me at this point.

I was a bit confused by the name of the new group, so I may rename that so it's easier to read. There's also some spurious spaces in the query which don't hurt.

@erikap erikap changed the base branch from master to development December 27, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants