Submit timesheet rework #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikap
requested changes
Dec 29, 2024
erikap
requested changes
Jan 7, 2025
app/components/alert.gjs
Outdated
| @@ -95,6 +111,12 @@ const IconSvg = <template> | |||
| d='M10 18a8 8 0 1 0 0-16 8 8 0 0 0 0 16Zm3.857-9.809a.75.75 0 0 0-1.214-.882l-3.483 4.79-1.88-1.88a.75.75 0 1 0-1.06 1.061l2.5 2.5a.75.75 0 0 0 1.137-.089l4-5.5Z' | |||
| clip-rule='evenodd' | |||
| ></path> | |||
| {{else if (eq @skin 'info')}} | |||
| <path | |||
There was a problem hiding this comment.
Can you use icons from bootstrap-icons with svg-jar. Makes it more consistent/readable/maintainable.
There was a problem hiding this comment.
fixed in 6ac8db0
app/components/checkbox.gjs
Outdated
|
|
||
| export default class CheckboxComponent extends Component { | ||
|
|
||
| onChange = (event) => { |
There was a problem hiding this comment.
Use active naming for action handler. E.g. change()
There was a problem hiding this comment.
fixed in 5362e77
app/components/timesheet-actions.js
Outdated
| }); | ||
| @action | ||
| clickAbsence(checked) { | ||
| if (!checked) { |
There was a problem hiding this comment.
Nickpicking, but why checking the negative case while you have similar if-else branches (and in clickTimesheet the check is reversed)
There was a problem hiding this comment.
fixed in 61a0b6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timesheet submit buttons were causing issues because they cannot be reverted. This brings back the checkboxes instead.