-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions #387
Add Github Actions #387
Conversation
607b12a
to
13eea5c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=========================================
Coverage ? 96.58%
=========================================
Files ? 30
Lines ? 468
Branches ? 113
=========================================
Hits ? 452
Misses ? 15
Partials ? 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b6bd76c
to
1ac29c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left out the review for publish.yml
, because it will depend on how review.yml
will be changed and it should follow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Looks good. Few comments on the publish workflow. Otherwise great progress and work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it's looking good now! Just small remark on whether to run lint
in release or not, but will let you decide.
No description provided.