Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Docusaurus with webpack 5 #4067

Merged
merged 7 commits into from
May 29, 2021

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Apr 16, 2021

Use an unreleased version of Docusaurus to test the webpack5 support works for this site.

See also facebook/docusaurus#4089

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c8e8902:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Apr 16, 2021

Deploy preview for redux-docs ready!

Built with commit c8e8902

https://deploy-preview-4067--redux-docs.netlify.app

@slorber slorber marked this pull request as ready for review April 30, 2021 17:43
@slorber
Copy link
Contributor Author

slorber commented Apr 30, 2021

ready for review

Copy link
Member

@msutkowski msutkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the majority of the content in both light & dark modes, and everything looks fine and nothing is obviously wrong. I spot-checked a handful of redirects, and no issues there either. All of the CSBs work as expected.

I'll give these changes a try against the RTK docs as well and see if there are any compatibility issues with the remark TS plugin.

@timdorr
Copy link
Member

timdorr commented May 1, 2021

LGTM

@slorber
Copy link
Contributor Author

slorber commented May 1, 2021

thanks :)

@markerikson markerikson merged commit 586084e into reduxjs:master May 29, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants