packages/cli: Switch from substr (deprecated) to slice (#9849)

redwoodjs · Jan 18, 2024 · f16b136 · f16b136
1 parent 6d74a22
commit f16b136
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/cli/src/commands/generate/service/service.js b/packages/cli/src/commands/generate/service/service.js
@@ -126,7 +126,7 @@ export const buildScenario = async (model) => {
       const value = scenarioData[key]
 
       if (value && typeof value === 'string' && value.match(/^\d+n$/)) {
-        scenarioData[key] = `${value.substr(0, value.length - 1)}n`
+        scenarioData[key] = `${value.slice(0, value.length - 1)}n`
       }
     })
 
@@ -141,13 +141,13 @@ export const buildScenario = async (model) => {
 export const buildStringifiedScenario = async (model) => {
   const scenario = await buildScenario(model)
 
-  return JSON.stringify(scenario, (key, value) => {
+  return JSON.stringify(scenario, (_key, value) => {
     if (typeof value === 'bigint') {
       return value.toString()
     }
 
     if (typeof value === 'string' && value.match(/^\d+n$/)) {
-      return Number(value.substr(0, value.length - 1))
+      return Number(value.slice(0, value.length - 1))
     }
 
     return value

diff --git a/packages/cli/src/commands/generate/service/templates/test.ts.template b/packages/cli/src/commands/generate/service/templates/test.ts.template
@@ -22,7 +22,7 @@
 
       // BigInt
       if (string.match(/^\"\d+n\"$/)) {
-        return string.substr(1, string.length - 2)
+        return string.slice(1, string.length - 1)
       }
 
       return string