Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteCacheKey() needs to include any global cache prefix #7362

Merged
merged 2 commits into from
Mar 2, 2023
Merged

deleteCacheKey() needs to include any global cache prefix #7362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf27d7
Use formatCacheKey() when deleting a key
cannikin Jan 16, 2023
7a7a12c
Merge branch 'main' into rc-delete-cache-key
cannikin Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/api/src/cache/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,19 +187,20 @@ export const createCache = (

const deleteCacheKey = async (key: CacheKey) => {
let result
const cacheKey = formatCacheKey(key, prefix)

try {
await Promise.race([
(result = client.del(key as string)),
(result = client.del(cacheKey as string)),
wait(timeout).then(() => {
throw new CacheTimeoutError()
}),
])

logger?.debug(`[Cache] DEL '${key}'`)
logger?.debug(`[Cache] DEL '${cacheKey}'`)
return result
} catch (e: any) {
logger?.error(`[Cache] Error DEL '${key}': ${e.message}`)
logger?.error(`[Cache] Error DEL '${cacheKey}': ${e.message}`)
return false
}
}
Expand Down