Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): disable rollbacks when using force #7679

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
Rollbacks occur even if a user has decided to force the command to run with the -f or --force flag. In this case it makes sense for rollbacks to be disabled.

I think this closes #7659. In that issues a separate bug is causing the command to fail and rollback however the user is happy to deal with any implications and wishes the command to run without a rollback. This would solve this issue because the user can now use -f to convey "I have understood the error and wish to proceed regardless."

Changes
The force option is also checked when checking for the rollback option in the command handlers.

@Josh-Walker-GM Josh-Walker-GM added release:fix This PR is a fix fixture-ok Override the test project fixture check labels Feb 23, 2023
@replay-io
Copy link

replay-io bot commented Feb 23, 2023

16 replays were recorded for 3ebe008.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/cb338616-7a6f-440d-9a95-8d678ed5ff64>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/b82d17a6-eabc-4bc4-8584-faff30d64236>Check that <meta> tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/30dd27c2-79ef-4209-9146-585091e0f7c5>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/dec16ec3-3ca2-40c0-a2e3-a185b84416a5>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/4614d646-30fe-439f-890e-ed36cdc2270e>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/fb78bd30-495c-4c75-b6b7-0991f49f4db1>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/7c92c0a2-7424-4731-ba54-17662571aa86>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/a3c8f6af-09ab-44a4-8af8-c0927ad6ba40>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/16df0df9-0791-4a07-8a4e-ffd3a9307624>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/31a700a6-4ca6-4e80-a861-a3ab092e8bdd>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/08f70578-fc34-4ff0-b775-58c99041fb32>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/928c7ca4-a806-4ca6-88fe-f0ee6ae5c93f>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/e39c66bb-b18e-4124-91bb-f80553645ea4>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/a3efea24-53f0-4c0a-9c8a-2af13d4ac585>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/db4bf276-8418-4844-8cc2-3db1394229ab>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar February 23, 2023 13:54
@jtoar jtoar merged commit 0033742 into main Mar 1, 2023
@jtoar jtoar deleted the jgmw-cli-no-rollbacks-with-force branch March 1, 2023 01:50
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 1, 2023
@jtoar jtoar modified the milestones: next-release, next-release-patch Mar 1, 2023
thedavidprice pushed a commit that referenced this pull request Mar 1, 2023
thedavidprice pushed a commit that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-ish]: Be less aggressive when rolling back errors during generation
3 participants