Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Clerk): call reauthenticate before navigating #7917

Merged
merged 6 commits into from
Mar 24, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 24, 2023

Our Clerk set up is broken right now. See this topic on the forums for details:

This is a fix suggested by the Clerk team. We may iterate on it still, but it's already been broken for some time and I don't want there to be more broken projects.

This doesn't help existing projects. I'm working on a codemod for that.

@jtoar jtoar added the release:fix This PR is a fix label Mar 24, 2023
@replay-io
Copy link

replay-io bot commented Mar 24, 2023

16 replays were recorded for 859c9b2.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/e90ca423-bca1-4994-af32-0d7b55e63a89>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/129f0e07-9d78-4298-8a01-8b373c829efc>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/bbd120c1-350b-4d18-a7bd-035a78722f01>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/ff30ddda-f7ed-4a19-81ac-7c2f9f75f0ab>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/44c2a9fb-cab4-4ea8-85a8-2e038ed74dbc>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/3e9212c8-9e40-4865-99a2-98d101506b3c>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/35e31517-63c2-45bd-a4f8-b041f8cbd65f>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/165bc156-9777-4d90-a9c9-cd224dae7142>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/56bd09a1-2a53-49f9-8aa7-0a76bfc172f3>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/82639abd-3373-42e4-b346-5cd678bd0556>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/d19ab5af-a612-4564-90d1-8568f80ab661>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/9415aee1-ede9-4522-bfb7-c827a0e8f6c8>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/9edd1450-bba8-41f8-97db-0d32bc900c48>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/60e4b48d-0f25-4eb5-a0b9-aa554a05f3ca>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/3749f2b7-4fb8-41d1-86f6-68612bd5dfb0>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar merged commit eb5c6aa into main Mar 24, 2023
@jtoar jtoar deleted the ds-clerk-redirect-template-fix branch March 24, 2023 23:38
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 24, 2023
jtoar added a commit that referenced this pull request Mar 25, 2023
* fix: call navigate before reauthenticate

* fix linting issues

* add back ClerkStatusUpdater

* add back hooks

* improve types
jtoar added a commit that referenced this pull request Mar 25, 2023
* fix: call navigate before reauthenticate

* fix linting issues

* add back ClerkStatusUpdater

* add back hooks

* improve types
dac09 added a commit to dac09/redwood that referenced this pull request Mar 28, 2023
* 'main' of github.com:redwoodjs/redwood: (162 commits)
  fix(deps): update dependency @escape.tech/graphql-armor to v1.8.0 (redwoodjs#7922)
  chore(deps): update dependency @playwright/test to v1.32.1 (redwoodjs#7924)
  chore(deps): update dependency @testing-library/dom to v9.2.0 (redwoodjs#7921)
  chore(deps): update dependency rimraf to v4 (redwoodjs#7907)
  fix(deps): update dependency react-hook-form to v7.43.8 (redwoodjs#7920)
  fix(deps): update dependency @fastify/http-proxy to v9 (redwoodjs#7889)
  fix(deps): update dependency @types/node to v16.18.20 (redwoodjs#7919)
  chore(deps): update dependency @replayio/playwright to v0.3.27 (redwoodjs#7918)
  fix(Clerk): call reauthenticate before navigating (redwoodjs#7917)
  chore(deps): update dependency esbuild to v0.17.13 (redwoodjs#7915)
  chore(deps): update dependency lerna to v6.6.1 (redwoodjs#7916)
  chore(deps): update dependency @tsd/typescript to v5 (redwoodjs#7856)
  chore(deps): update dependency @testing-library/dom to v9.1.0 (redwoodjs#7914)
  fix(deps): update dependency msw to v1.2.1 (redwoodjs#7911)
  chore(deps): update dependency @types/react to v18.0.29 (redwoodjs#7912)
  chore(deps): update dependency nx to v15.8.9 (redwoodjs#7913)
  Fix for directUrl usage during testing (redwoodjs#7898)
  fix(deps): update dependency prettier to v2.8.7 (redwoodjs#7908)
  chore(deps): update dependency @nrwl/nx-cloud to v15.3.2 (redwoodjs#7904)
  fix(deps): update dependency @types/node to v16.18.19 (redwoodjs#7906)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant