Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump API build target 16.20 #7995

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Conversation

thedavidprice
Copy link
Contributor

The latest Node.js v16 LTS release is 16.20

Projects will need to upgrade local dev and serverless functions to support > 16.20

For providers like Vercel and Netlify, unless there's a set semver minor (rare), I expect this to be fine.

Note: as of now, Netlify does NOT support AWS Lambdas on v18, which is the only reason we've held off from bumping everything to v18

@thedavidprice thedavidprice added the fixture-ok Override the test project fixture check label Apr 1, 2023
@thedavidprice thedavidprice requested a review from jtoar April 1, 2023 23:41
@thedavidprice thedavidprice added the release:breaking This PR is a breaking change label Apr 1, 2023
@thedavidprice thedavidprice added this to the v5.0.0 milestone Apr 1, 2023
@jtoar jtoar enabled auto-merge (squash) April 1, 2023 23:50
@replay-io
Copy link

replay-io bot commented Apr 1, 2023

16 replays were recorded for 892b3e3.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/a61a3229-4597-4af5-b5fd-9c223e7a350f>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/3437b86f-34d1-4610-956b-deb14a181b7a>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/bc408cf6-b091-44db-96eb-f472637f2b9e>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/22166f9d-ea96-4212-9887-4ad7d4d4cfcc>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/e3af3ae3-23e3-460c-957a-9e0931407d26>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/8b2d56ee-936e-4bb1-89c7-f5e6a438a71e>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/a3e35cb9-19ee-450e-aee3-177bace5ce9a>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/15e872ea-fb27-411b-be87-3bf9caf62ba9>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/d3e9bfb5-4697-4598-ae1f-c1293fbac418>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/6ea6a312-eef9-4770-b246-7990e7414f70>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/e2d17f26-cf5a-406e-9dba-0acf58144c10>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/b8c20d6e-37f9-4d17-b815-65aee73d3b61>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/210974ae-bf16-4614-a267-f76ce5476c94>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/a3538973-3914-427c-8fe7-f25d3c3d78af>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/b4927db4-0870-4fe2-b2c4-9ffd9a57319d>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@thedavidprice thedavidprice disabled auto-merge April 2, 2023 00:15
@thedavidprice thedavidprice merged commit 7ae6aed into main Apr 2, 2023
@thedavidprice thedavidprice deleted the dsp-bump-api-build-target branch April 2, 2023 00:15
@redwoodjs-bot redwoodjs-bot bot modified the milestones: v5.0.0, next-release Apr 2, 2023
@jtoar jtoar modified the milestones: next-release, v4.5.0, v5.0.0 Apr 2, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Apr 3, 2023
* 'main' of github.com:redwoodjs/redwood: (66 commits)
  update template README
  bumps API build target 16.20; fixtures updated (redwoodjs#7995)
  remove serverless deploy option (redwoodjs#7993)
  chore(deps): update dependency @clerk/types to v3.33.0 (redwoodjs#7991)
  feat(clerk auth): make `getToken` options globally configurable (redwoodjs#7947)
  chore(deps): update dependency firebase to v9.19.1 (redwoodjs#7986)
  fix(deps): update dependency webpack-dev-server to v4.13.2 (redwoodjs#7989)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.8.1 (redwoodjs#7988)
  fix upgrade.js error message (redwoodjs#7992)
  fix(clerk auth): set auth state to loading while reauthenticating (redwoodjs#7852)
  chore(deps): update dependency @supabase/supabase-js to v2.13.1 (redwoodjs#7981)
  chore(deps): update dependency @clerk/clerk-react to v4.14.1 (redwoodjs#7987)
  chore: unpublish packages script (redwoodjs#7990)
  chore(deps): update dependency nx to v15.9.2 (redwoodjs#7983)
  chore(deps): update dependency @nrwl/nx-cloud to v15.3.5 (redwoodjs#7985)
  fix(deps): update dependency @apollo/client to v3.7.11 (redwoodjs#7984)
  chore(deps): update dependency @tsd/typescript to v5.0.3 (redwoodjs#7978)
  chore(deps): update dependency typescript to v5.0.3 (redwoodjs#7972)
  chore(deps): update dependency @nrwl/nx-cloud to v15.3.4 (redwoodjs#7977)
  chore(deps): update dependency nx to v15.9.1 (redwoodjs#7976)
  ...
jaiakt pushed a commit to jaiakt/redwood that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:breaking This PR is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants