Fallback to auth-provider header case #8368
Conversation
There was a problem hiding this comment.
I'd rather handle this in a holistic way (i.e. make sure all header casing is normalized, etc.), but since this doesn't do any harm (it's just an additional check) and @gilliardmacedo needs this and contributed a fix, let's get this out in a RC and then a patch
* Fallback to auth-provider header case * fix method casing * prefer ?? to || for undefined conditional * lint fix --------- Co-authored-by: Dominic Saadi <[email protected]>
* Fallback to auth-provider header case * fix method casing * prefer ?? to || for undefined conditional * lint fix --------- Co-authored-by: Dominic Saadi <[email protected]>
…te-default * 'main' of github.com:redwoodjs/redwood: chore(deps): update dependency dependency-cruiser to v13.0.2 (redwoodjs#8381) fix(coherence): fix health check path (redwoodjs#8380) fix(deps): update dependency graphql-scalars to v1.22.0 (redwoodjs#8356) fix(deps): update dependency eslint to v8.41.0 (redwoodjs#8376) chore(deps): update dependency glob to v10.2.6 (redwoodjs#8379) fix(deps): update dependency @tremor/react to v2.7.0 (redwoodjs#8361) chore(deps): update dependency @playwright/test to v1.34.0 (redwoodjs#8377) fix(deps): update dependency style-loader to v3.3.3 (redwoodjs#8369) fix(deps): update dependency vite to v4.3.8 (redwoodjs#8371) fix(deps): update dependency css-loader to v6.7.4 (redwoodjs#8365) fix(deps): update dependency mini-css-extract-plugin to v2.7.6 (redwoodjs#8366) Fallback to auth-provider header case (redwoodjs#8368) feat(cli): Experimental support for plugins (redwoodjs#8316) fix(deps): update dependency @clerk/clerk-sdk-node to v4.9.2 (redwoodjs#8364) chore(deps): update dependency octokit to v2.0.16 (redwoodjs#8370) chore(deps): update dependency vite to v4.3.8 (redwoodjs#8355) chore(deps): update dependency @clerk/types to v3.38.1 (redwoodjs#8363)
|
I am probably just confused by the process here, I see this in 5.2.2-rc.0 and the main branch but not in the last release (5.2.3), can someone tell me why? |
|
This PR is a special case where the team didn't feel comfortable releasing it in a stable version yet. I got the RC out for @gilliardmacedo in the meantime. Are you affected too @standup75? |
|
Sorry for the late reply. It does affect me too, but Gilliard and I are working on the same project :) |
|
@standup75 don't worry, and I just talked to @thedavidprice—we'll release this in the next minor, sound good? |
Awesome thank you |
* Fallback to auth-provider header case * fix method casing * prefer ?? to || for undefined conditional * lint fix --------- Co-authored-by: Dominic Saadi <[email protected]>
* Fallback to auth-provider header case * fix method casing * prefer ?? to || for undefined conditional * lint fix --------- Co-authored-by: Dominic Saadi <[email protected]>
|
@standup75, @gilliardmacedo we just released a fix for this in v5.2.4. We went with a slightly different implementation but it should cover your use case still: #8474. |
|
Awesome thank you |
I'm proposing a solution for #8367