Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp(studio): Minor UI changes and fix for span events list #8394

Merged
merged 6 commits into from
May 24, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Changes

  • Switches more of the general UI components to be tremor based.
  • Fixes an issue where span events would crash the span page.
  • Provides a modal to show event information
  • Highlights the error status of spans when they are listed in various pages
  • Prepares an error link to a dedicated error viewing page - not implement yet.
  • Improves the OTel wrapper babel plugin:
    • Sets the file and function attributes earlier to ensure they are set even if the function throws an error
    • Sets the spans status appropriately when an error is thrown

Visual changes:

2023-05-23_13-59-32.mp4

Future work

  • Implement the dedicated error page
  • Implement the error monitoring page

Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatToMe. Like that the UI is more tremor components!

@replay-io
Copy link

replay-io bot commented May 23, 2023

@dthyresson dthyresson merged commit e6eca96 into main May 24, 2023
@dthyresson dthyresson deleted the jgmw-studio/ui-update branch May 24, 2023 14:42
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 24, 2023
jtoar pushed a commit that referenced this pull request May 24, 2023
* Update UI components to use tremor. Fix span events listing.

* fix events UI and rework span page/component

* Improve OTel automatic wrapping.

We should set the code and function attributes at the earliest point. Set span error code.

---------

Co-authored-by: David Thyresson <[email protected]>
@jtoar jtoar modified the milestones: next-release, v5.3.0 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants