Only use the main lodash package #8583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:chore
jtoar
approved these changes
Jun 12, 2023
jtoar
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Only use the main lodash package * import from lodash * Make it easier to tree-shake lodash imports * Try to disable replay for smoke tests * Always use the 'list' reporter for smoke tests * require just lodash * lodash camelCase import * lodash camelCase import 2 * Restore playwright config * Only 'lodash'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading this and figured I'd clean up our usage of lodash
https://lodash.com/per-method-packages
Should we make sure to always just include from specific parts of lodash, like doing
import memoize from 'lodash/memoize', or can we trust our bundler to tree-shake that stuff for us? The lodash docs says we can, so that's why I didn't go through our code and update all imports.Only thing I'm not sure about is usage like this:
Does tree-shaking work with code like that?
UPDATE: I decided to switch to specific method imports everywhere, like
import { forEachRight } from 'lodash'