deprecate setup ui windicss (project is sunsetting)
#8597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
reviewed
Jun 13, 2023
| @@ -8,10 +8,24 @@ import { errorTelemetry } from '@redwoodjs/telemetry' | |||
|
|
|||
| import { getPaths } from '../../../../lib' | |||
| import c from '../../../../lib/colors' | |||
| import { printSetupNotes } from '../helpers' | |||
There was a problem hiding this comment.
Just tried running this locally and it seems like this file doesn't exist at this location; this specific helper is co-located with the deploy commands at the moment. Don't see why we can't move it, we probably just never had a reason to
jtoar
added
release:fix
|
I'm seeing errors in the CLI tests I've seen in my other PR here: #8448. I'm not savvy enough with Jest to know what I'm doing wrong with the mocks. And it's late so I'll try again another time |
|
Thanks for the help with this one @jtoar Setting to auto-merge now. |
jtoar
added a commit
that referenced
this pull request
Jun 22, 2023
* deprecate setup ui windicss * move printSetupNotes * fix rest of imports * fix mocking in netlify * Update packages/cli/src/commands/setup/ui/libraries/windicss.js --------- Co-authored-by: Dominic Saadi <[email protected]>
|
Why not migrate to Unocss? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1 of 2
The WindiCSS project is sunsetting. One of the recommended replacements is Tailwind CSS, which is already supported. See: https://windicss.org/posts/sunsetting.html
This PR indicates
deprecatedin the setup command and CLI docs. (target v5.4)The follow-up PR will remove the setup command entirely. (target v6) #8598
Note: Projects using Windi CSS will not be affected when upgrading. Redwood v6 switches to Vite as the default bundler (Webpack supported but deprecated). At that time, if projects using Windi CSS upgrade to v6 and want to use Vite, they'll need to follow the Windi + Vite installation guide to manually make the changes to upgrade: https://windicss.org/integrations/vite.html