Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(studio): update tremor to v3 #8645

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Jun 16, 2023

Tremor released v3 with the changelog here. This PR updates the studio frontend in accordance with the new v3 api.

See #8560 that triggered this.

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Jun 16, 2023
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my test, seems there is a background issue in select lists:

image

@dthyresson
Copy link
Contributor

dthyresson commented Jun 18, 2023

Also, tremor has released 3.2.2 since this PR to fix some regressions; perhaps this is one.

Although, it's as if styles aren't being set at all when I ran locally:

image

@Josh-Walker-GM
Copy link
Collaborator Author

Hmm okay I can take another look and check. Things looked okay when I pushed up but I'll double check of course.

@dthyresson
Copy link
Contributor

I did a new test project and then rwfw project sync; setup open telemetry, start studio.

Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired and demo'd to see v3 working well.

@dthyresson dthyresson enabled auto-merge (squash) June 20, 2023 12:58
Copy link
Contributor

➕ Pushed commit: Merge branch 'main' into jgmw-studio/update-tremor

@dthyresson dthyresson merged commit 715f6a4 into main Jun 20, 2023
@dthyresson dthyresson deleted the jgmw-studio/update-tremor branch June 20, 2023 14:04
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 20, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Jun 21, 2023
…redwood into codemod/replace-svg-as-components

* 'codemod/replace-svg-as-components' of github.com:dac09/redwood:
  chore(deps): update react monorepo (redwoodjs#8677)
  chore(deps): update dependency postcss to v8.4.24 (redwoodjs#8675)
  chore(deps): update dependency esbuild to v0.18.6 (redwoodjs#8670)
  chore(deps): update dependency dependency-cruiser to v13.0.4 (redwoodjs#8674)
  chore(deps): update dependency autoprefixer to v10.4.14 (redwoodjs#8668)
  chore(deps): update dependency @clerk/clerk-react to v4.20.5 (redwoodjs#8672)
  Fix typos in documentation (redwoodjs#8659)
  fix(docs): Fix & make verifyOwnership consistent (redwoodjs#8596)
  chore(deps): update dependency vite to v4.1.5 [security] (redwoodjs#8671)
  fix(deps): update dependency react-hook-form to v7.45.0 (redwoodjs#8664)
  chore(studio): update tremor to v3 (redwoodjs#8645)
  fix(deps): update dependency webpack to v5.87.0 (redwoodjs#8549)
  fix(deps): update dependency dotenv to v16.3.1 (redwoodjs#8663)
  chore(deps): update dependency @clerk/clerk-react to v4.20.4 (redwoodjs#8662)
  fix(vite): Change config for mantine and chakra to use export default (redwoodjs#8639)
  fix(deps): update storybook monorepo to v7.0.22 (redwoodjs#8652)
  Fix failing v5 codemod for DevFatalErrorPage (redwoodjs#8661)
jtoar pushed a commit that referenced this pull request Jun 22, 2023
* Update to tremor v3

* Update frontend-dist

* Update tremor to latest and add theming

Also pins the dependencies.

* Update the frontend-dist

---------

Co-authored-by: David Thyresson <[email protected]>
@jtoar jtoar modified the milestones: next-release, v5.4.0 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants