eslint rule: unsupported-route-components #8774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-eslint-router-elements
branch
from
706da9b to
56c3634
Compare
Tobbe
force-pushed
the
tobbe-eslint-router-elements
branch
from
56c3634 to
f952e2f
Compare
jtoar
approved these changes
Jun 29, 2023
jtoar
suggested changes
Jun 29, 2023
jtoar
reviewed
Jun 29, 2023
jtoar
approved these changes
Jun 29, 2023
jtoar
pushed a commit
that referenced
this pull request
Jun 29, 2023
jtoar
pushed a commit
that referenced
this pull request
Jun 29, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our router file officially really only supports
<Router>,<Route>,<Set>and<Private>elements.Unofficially you've been able to use other things, like
<div>and stuff in certain places. But with the new Suspense enabled router we're introducing that's not going to be possible anymore.So this is an eslint rule that for now only warns on unsupported elements. But when the new router is released we can change that to show an error instead of a warning