Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Better error handling in detectChanges.mjs #9762

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 27, 2023

image

Getting changed files for PR 9761 (page 1)
file:///home/runner/work/redwood/redwood/.github/actions/detect-changes/detectChanges.mjs:[5](https://github.com/redwoodjs/redwood/actions/runs/7336363781/job/19975570203?pr=9761#step:6:6)3
  const files = json.map((file) => file.filename) || []
                     ^

TypeError: json.map is not a function
    at getChangedFiles (file:///home/runner/work/redwood/redwood/.github/actions/detect-changes/detectChanges.mjs:53:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/runner/work/redwood/redwood/.github/actions/detect-changes/detectChanges.mjs:[7](https://github.com/redwoodjs/redwood/actions/runs/7336363781/job/19975570203?pr=9761#step:6:8)[8](https://github.com/redwoodjs/redwood/actions/runs/7336363781/job/19975570203?pr=9761#step:6:9):24)

Node.js v20.8.1

https://github.com/redwoodjs/redwood/actions/runs/7336363781/job/19975570203?pr=9761

This PR tries to better handle the situation above

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Dec 27, 2023
@Tobbe Tobbe added this to the chore milestone Dec 27, 2023
@Tobbe Tobbe enabled auto-merge (squash) December 27, 2023 08:39
@Tobbe Tobbe merged commit c6e92b2 into redwoodjs:main Dec 27, 2023
31 of 35 checks passed
dac09 added a commit to dac09/redwood that referenced this pull request Dec 28, 2023
…p-prebuild

* 'main' of github.com:redwoodjs/redwood: (1608 commits)
  Docker: Update to work with corepack and yarn v4 (redwoodjs#9764)
  [RFC]: useRoutePaths (redwoodjs#9755)
  Adds a note about the two commands you will use with your schema to the top of the schema file (redwoodjs#8589)
  docs: Supertokens.md: Fix typo (redwoodjs#9765)
  Fix supertokens docs & integration issues (redwoodjs#9757)
  fix(apollo): Enhance error differently for Suspense Cells (redwoodjs#9640)
  SSR smoke-test: Use <Metadata /> (redwoodjs#9763)
  chore(deps): update dependency @types/qs to v6.9.11 (redwoodjs#9761)
  chore(ci): Better error handling in detectChanges.mjs (redwoodjs#9762)
  fix(path-alias): Fix aliasing of paths using ts/jsconfig (redwoodjs#9574)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  ...
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants