fix: cannot update Label props (close #92)

reearth · Jul 3, 2019 · f6f5a0a · f6f5a0a
1 parent 6e3fd80
commit f6f5a0a
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/Label/Label.ts b/src/Label/Label.ts
@@ -46,7 +46,7 @@ export interface LabelCesiumProps {
 export interface LabelProps extends LabelCesiumProps, EventProps<Cesium.Label> {}
 
 export interface LabelContext {
-  labelCollection?: Cesium.LabelCollection;
+  labelCollection: Cesium.LabelCollection;
   __RESIUM_EVENT_MANAGER?: EventManager;
 }
 
@@ -79,15 +79,12 @@ const cesiumProps: (keyof LabelCesiumProps)[] = [
 const Label = createCesiumComponent<Cesium.Label, LabelProps, LabelContext>({
   name: "Label",
   create(cprops, props, context) {
-    return new (Cesium.Label as any)(cprops, context.labelCollection);
+    return context.labelCollection.add(cprops);
   },
   mount(element, context, props) {
     if (context.__RESIUM_EVENT_MANAGER) {
       context.__RESIUM_EVENT_MANAGER.setEvents(element, props);
     }
-    if (context.labelCollection) {
-      context.labelCollection.add(element);
-    }
   },
   unmount(element, context) {
     if (context.__RESIUM_EVENT_MANAGER) {