Shorten all authentication helpers #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ugisozols how would you like to write deprecations for the old paths? |
|
No idea but we'll figure out something. |
|
@ugisozols were you saying that you worked out deprecations? |
|
Haven't figured it out ... |
|
Can we merge this in master without deprecations and figure out 2.0.x deprecations later? |
|
No it would be a nasty surprise for 2.1 people. I'd prefer the patch |
|
This can't merge anymore; I guess we changed something! |
|
Merged - maybe we can deprecate but we can for sure blog + tweet + changelog it |
ugisozols
added a commit
that referenced
this pull request
Jun 11, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, authentication helpers were long and tedious to type out:
new_refinery_user_session_path_the_quest_for_a_longer_method_name_part_two. It is unnecessary for them to be this long.login_pathwill do just fine, because the engine is now isolated. There's three new helpers:login_*,logout_*andsignup_*.I don't know how you deal with deprecation of the old ones, so I've just gone ahead and changed them now.