Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1585. #1882

Merged
merged 2 commits into from
Aug 15, 2012
Merged

Fixes #1585. #1882

merged 2 commits into from
Aug 15, 2012

Conversation

robyurkowski
Copy link
Contributor

Sorting 11 items without reordering should be a no-op. However, if we sort the array by the given keys—which are strings—this will actually sort the 11th entry after the 2nd (producing an lft of 5, instead of an expected 21).

EDIT: I cannot count.

@robyurkowski
Copy link
Contributor Author

This will fix #1585.

@travisbot
Copy link

This pull request fails (merged dc36f082 into 5e22bab).

@travisbot
Copy link

This pull request fails (merged 4c85486 into 5e22bab).

@parndt parndt merged commit 4c85486 into master Aug 15, 2012
@parndt
Copy link
Member

parndt commented Aug 15, 2012

And cherry-picked to 2-0-stable for you.

robyurkowski added a commit that referenced this pull request Aug 15, 2012
robyurkowski added a commit that referenced this pull request Aug 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants