Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese locale #2007

Closed
wants to merge 5 commits into from
Closed

Add Portuguese locale #2007

wants to merge 5 commits into from

Conversation

davidslvto
Copy link

Hello there,

I'm adding the Portuguese from Portugal in the locales.

@ugisozols
Copy link
Member

Hey @Davidslv,

Thanks for the PR!

Are you planing to translate other parts of Refinery too?

@davidslvto
Copy link
Author

I didn't plan more translations, I just start using refinerycms, but if there are more things to be translated it will be my pleasure to do it.

@ugisozols
Copy link
Member

By other parts I mean engines of which Refinery CMS consists of like dashboard, images, pages and others. Each of them have locales so it's not only the Core ones :)

Locales for:

- Dashboard
- Images
- Pages (removed the old pt-PT.yml)
@davidslvto
Copy link
Author

There you have them =)

- Authentication
- Resources
@@ -0,0 +1,72 @@
en:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to pt:

@parndt
Copy link
Member

parndt commented Nov 6, 2012

Thanks @davidslvto !!!

@ugisozols I updated your comments from :pt to pt:

@parndt
Copy link
Member

parndt commented Nov 6, 2012

Whoa, you have two GitHub accounts :)

@ugisozols
Copy link
Member

Thanks @parndt! I need to wake up :)

@davidslvto
Copy link
Author

Hi guys,

@parndt Yes this one is used for work and the other one is my personal (Davidslv)

I'm sorry for the mistake, it was so late yesterday that I didn't realize that mistake.

@ugisozols
Copy link
Member

@Davidslv there's one more place where you need to change en: to pt:. See my comment above. After that we can merge.

@parndt
Copy link
Member

parndt commented Nov 6, 2012

This is actually the most common feedback we have when people
contribute translations :-) thanks for your help!

@davidslvto
Copy link
Author

No problem :)

@ugisozols
Copy link
Member

I squashed and merged your PR in 6f06960. Thank you @Davidslv for contributing!

@ugisozols ugisozols closed this Nov 7, 2012
ugisozols added a commit that referenced this pull request Nov 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants