Add data-index attribute to newly created page parts. #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is needed because page part ordering sets page part position using data-index value.
| @@ -602,6 +602,9 @@ var page_options = { | |||
| // Add a new tab for the new content section. | |||
| $('#page_part_editors').append(data); | |||
| page_options.tabs.tabs('add', '#page_part_new_' + $('#new_page_part_index').val(), part_title); | |||
| // this is here because of https://github.com/refinery/refinerycms/issues/2060 | |||
There was a problem hiding this comment.
Will this comment show up in the compiled version?
There was a problem hiding this comment.
tbh I have no idea.
Should I remove it?
parndt
added a commit
that referenced
this pull request
Dec 5, 2012
Add data-index attribute to newly created page parts.
ugisozols
added a commit
that referenced
this pull request
Dec 5, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2060
It is needed because page part ordering sets page part position using data-index value.