Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run auto-tick with a single package only #2813

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Jun 26, 2024

This PR adds an argument to the auto-tick command allowing it to be run with a single package only for easier debugging.

Cc @pavelzw

  • Pydantic model updated or no update needed
  • Add an Integration Test (see comment)

@ytausch ytausch force-pushed the auto-tick-single-package branch from 2ed9925 to 78ca5a9 Compare November 11, 2024 17:12
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 33 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (6d941e7) to head (3acde80).

Files with missing lines Patch % Lines
conda_forge_tick/auto_tick.py 21.95% 32 Missing ⚠️
conda_forge_tick/make_migrators.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
- Coverage   77.80%   77.71%   -0.09%     
==========================================
  Files         128      128              
  Lines       13841    13880      +39     
==========================================
+ Hits        10769    10787      +18     
- Misses       3072     3093      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytausch ytausch force-pushed the auto-tick-single-package branch 2 times, most recently from a694936 to e645003 Compare November 18, 2024 12:19
@ytausch ytausch force-pushed the auto-tick-single-package branch from e645003 to 8cd8a0d Compare November 25, 2024 10:12
@ytausch ytausch marked this pull request as ready for review November 25, 2024 10:14
@ytausch ytausch requested a review from beckermr November 25, 2024 10:15
@ytausch
Copy link
Contributor Author

ytausch commented Nov 25, 2024

Since it's still very burdensome to add a fully-fledged integration/end-to-end test for the auto-tick command, I decided to skip it for now. When we deal with #261, we might also have a look at testing the dry-run mode.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some initial comments. package needs to be changed to feedstock everywhere. After the existing comments are addressed, I'll take another look.

@ytausch ytausch force-pushed the auto-tick-single-package branch from 45050de to 3d2ed2a Compare November 25, 2024 12:37
@ytausch ytausch requested a review from beckermr November 25, 2024 12:43
@ytausch ytausch force-pushed the auto-tick-single-package branch from cb5edda to fcd48e6 Compare November 25, 2024 16:38
tests/test_upstream_versions.py Outdated Show resolved Hide resolved
conda_forge_tick/cli.py Outdated Show resolved Hide resolved
tests/test_upstream_versions.py Outdated Show resolved Hide resolved
@ytausch ytausch force-pushed the auto-tick-single-package branch from 2c9259f to 05bdf9a Compare November 30, 2024 22:41
@ytausch ytausch requested a review from pavelzw November 30, 2024 22:41
@ytausch
Copy link
Contributor Author

ytausch commented Nov 30, 2024

pre-commit.ci autofix

@ytausch ytausch force-pushed the auto-tick-single-package branch from 5255be0 to 3acde80 Compare December 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants