Fix checking of Rails version on ActiveRecord log subscriber #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't check only for Rails 7, check for all version after also (Rails 8 and the future ones).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#249
Description of changes
Don't check only for Rails 7, check for all version after also (Rails 8 and the future ones).
I see that on other parts of code you have conditions where you check if Rails version is bigger than 7 so I think this would be good to have for compatibility with new Rails versions. Of course, if there would be some needed changes in some Rails version in future, we would add new condition, but in case there is no need for that like now on Rails 8, we wouldn't have errors.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.