Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump isort from 4.3.21 to 5.0.5 #45

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 9, 2020

Bumps isort from 4.3.21 to 5.0.5.

Release notes

Sourced from isort's releases.

5.0.5 July 7, 2020

  • Fixed #1285: packaging issue with bundling tests via poetry.
  • Fixed #1284: Regression when sorting .pyi files from CLI using black profile.
  • Fixed #1275 & #1283: Blank line after docstring removed.
  • Fixed #1298: CLI Help out of date with isort 5.
  • Fixed #1290: Unecessary blank lines above nested imports when import comments turned on.
  • Fixed #1297: Usage of --add-imports alongside --check is broken.
  • Fixed #1289: Stream usage no longer auto picking up config file from current working directory.
  • Fixed #1296: Force_single_line setting removes immediately following comment line.
  • Fixed #1295: ensure_newline_before_comments doesnt work with force_sort_within_sections.
  • Setting not_skip will no longer immediately fail but instead give user a warning and direct to upgrade docs.

5.0.4

No release notes provided.

5.0.3 - July 4, 2020

  • Fixed setup.py command incorrectly passing check=True as a configuration parameter (see: timothycrosley/isort#1258)
  • Fixed missing patch version
  • Fixed issue #1253: Atomic fails when passed in not readable output stream

5.0.2

Ensure completeness of black profile, adding default line_length

5.0.1

No release notes provided.

5.0.0

https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/

4.3.21-2

4.3.21 - June 25, 2019 - hot fix release

  • Fixed issue #957 - Long aliases and use_parentheses generates invalid syntax
Changelog

Sourced from isort's changelog.

5.0.5 July 7, 2020

  • Fixed #1285: packaging issue with bundling tests via poetry.
  • Fixed #1284: Regression when sorting .pyi files from CLI using black profile.
  • Fixed #1275 & #1283: Blank line after docstring removed.
  • Fixed #1298: CLI Help out of date with isort 5.
  • Fixed #1290: Unecessary blank lines above nested imports when import comments turned on.
  • Fixed #1297: Usage of --add-imports alongside --check is broken.
  • Fixed #1289: Stream usage no longer auto picking up config file from current working directory.
  • Fixed #1296: Force_single_line setting removes immediately following comment line.
  • Fixed #1295: ensure_newline_before_comments doesnt work with force_sort_within_sections.
  • Setting not_skip will no longer immediately fail but instead give user a warning and direct to upgrade docs.

5.0.4 July 6, 2020

  • Fixed #1264: a regression with comment handling and force_sort_within_sections config option
  • Added warning for deprecated CLI flags and linked to upgrade guide.

5.0.3 - July 4, 2020

  • Fixed setup.py command incorrectly passing check=True as a configuration parameter (see: timothycrosley/isort#1258)
  • Fixed missing patch version
  • Fixed issue #1253: Atomic fails when passed in not readable output stream

5.0.2 - July 4, 2020

  • Ensured black profile was complete, adding missing line_length definition.

5.0.1 - July 4, 2020

  • Fixed a runtime error in a vendored dependency (toml).

5.0.0 Penny - July 4, 2020

Breaking changes:

  • isort now requires Python 3.6+ to run but continues to support formatting on ALL versions of python including Python 2 code.
  • isort deprecates official support for Python 3.4, removing modules only in this release from known_standard_library:
    • user
  • Config files are no longer composed on-top of each-other. Instead the first config file found is used.
    • Since there is no longer composition negative form settings (such as --dont-skip or it's config file variant not_skip) are no longer required and have been removed.
  • Two-letter shortened setting names (like ac for atomic) now require two dashes to avoid ambiguity: --ac.
  • For consistency with other tools -v now is shorthand for verbose and -V is shorthand for version. See Issue: #1067.
  • length_sort_{section_name} config usage has been deprecated. Instead length_sort_sections list can be used to specify a list of sections that need to be length sorted.
  • safety_excludes and unsafe have been deprecated
  • Config now includes as default full set of safety directories defined by safety excludes.
  • --recursive option has been removed. Directories passed in are now automatically sorted recursive.
  • --apply option has been removed as it is the default behaviour.
  • isort now does nothing, beyond giving instructions and exiting status code 0, when ran with no arguments.
    • a new --interactive flag has been added to enable the old style behaviour.
  • isort now works on contiguous sections of imports, instead of one whole file at a time.
  • isort now formats all nested "as" imports in the "from" form. import x.y as a becomes from x import y as a.
  • keep_direct_and_as_imports option now defaults to True.
  • appdirs is no longer supported. Unless manually specified, config should be project config only.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 9, 2020
@rohanpm
Copy link
Member

rohanpm commented Jul 9, 2020

It's interesting that this came up so soon after setting up dependabot. isort 5 had backwards-incompatible API changes which break pylint - pylint-dev/pylint#3722

If we didn't pin dependency versions, I think this would have broken CI. Other projects are having to do workarounds, e.g. syslog-ng/syslog-ng#3351

I guess the right thing to do in this case is just leave the PR open until a new pylint comes out which isn't broken with isort 5, triggering its own dependabot PR, at which point this one starts to pass CI.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 9, 2020

Superseded by #46.

@dependabot dependabot bot closed this Jul 9, 2020
@dependabot dependabot bot deleted the dependabot/pip/isort-5.0.5 branch July 9, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant