fix(index): include domhandler Node in DOMNode type

Fixes #207
remarkablemark · Jan 12, 2021 · ac4aff3 · ac4aff3
1 parent a4f945b
commit ac4aff3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -5,6 +5,7 @@ import {
   Comment,
   DomHandlerOptions,
   Element,
+  Node,
   ProcessingInstruction,
   Text
 } from 'domhandler';
@@ -15,8 +16,8 @@ import domToReact from './lib/dom-to-react';
 
 export { attributesToProps, domToReact, htmlToDOM };
 export type HTMLParser2Options = ParserOptions & DomHandlerOptions;
-export { Comment, Element, ProcessingInstruction, Text };
-export type DOMNode = Comment | Element | ProcessingInstruction | Text;
+export { Comment, Element, Node, ProcessingInstruction, Text };
+export type DOMNode = Comment | Element | Node | ProcessingInstruction | Text;
 
 export interface HTMLReactParserOptions {
   htmlparser2?: HTMLParser2Options;

diff --git a/test/types/index.tsx b/test/types/index.tsx
@@ -39,14 +39,24 @@ parse('<br id="remove">', {
   }
 });
 
-const options: HTMLReactParserOptions = {
+let options: HTMLReactParserOptions;
+
+options = {
   replace: domNode => {
     if (domNode instanceof Element && domNode.attribs.id === 'header') {
       return;
     }
   }
 };
 
+options = {
+  replace: domNode => {
+    if (domNode instanceof Element) {
+      return <>{domToReact(domNode.children)}</>;
+    }
+  }
+};
+
 // $ExpectType string | Element | Element[]
 parse('<a id="header" href="#">Heading</a>', options);
 
@@ -76,7 +86,7 @@ parse('<p/><p/>', {
 // $ExpectType string | Element | Element[]
 parse('\t<p>text \r</p>\n', { trim: true });
 
-// $ExpectType DOMNode[]
+// $ExpectType (Comment | Element | ProcessingInstruction | Text)[]
 const domNodes = htmlToDOM('<div>text</div>');
 
 // $ExpectType string | Element | Element[]

diff --git a/test/types/lib/dom-to-react.tsx b/test/types/lib/dom-to-react.tsx
@@ -4,7 +4,7 @@ import domToReact from 'html-react-parser/lib/dom-to-react';
 import * as React from 'react';
 import htmlToDOM from 'html-dom-parser';
 
-// $ExpectType DOMNode[]
+// $ExpectType (Comment | Element | ProcessingInstruction | Text)[]
 htmlToDOM('<div>text</div>');
 
 // $ExpectType string | Element | Element[]