Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option htmlparser2 #161

Merged
merged 9 commits into from
Jun 4, 2020
Merged

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Jun 3, 2020

What is the motivation for this pull request?

feature

  • add option htmlparser2

Closes #158

What is the current behavior?

No way to pass options to html-dom-parser, which uses htmlparser2 on Node.js (server-side)

What is the new behavior?

Ability to pass options to htmlparser2 from library options

Checklist:

  • Tests
  • Documentation

@remarkablemark remarkablemark added the feature New feature or request label Jun 3, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5944dd8 on feat/options-htmlparser2 into 0078b2a on master.

@@ -224,6 +224,34 @@ parse('<br>', {
});
```

### htmlparser2
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rburgst
Copy link

rburgst commented Jun 4, 2020

Awesome!

@remarkablemark remarkablemark merged commit 4db43eb into master Jun 4, 2020
@remarkablemark remarkablemark deleted the feat/options-htmlparser2 branch June 4, 2020 22:43
@remarkablemark
Copy link
Owner Author

Published 0.12.0:

npm:

yarn:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to use htmlparser2 xmlMode
4 participants