Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacing hash path in various edge cases #209

Closed
wants to merge 1 commit into from

Conversation

taion
Copy link
Contributor

@taion taion commented Jan 15, 2016

Fixes #126

@taion
Copy link
Contributor Author

taion commented Jan 16, 2016

Looks like this isn't quite okay on Firefox.

@agundermann
Copy link
Contributor

Yeah, this reloads when using <base> tag that doesn't match current URL (test). Fails locally with Chrome, too.

useBasename in combination with hash history and <base> tag doesn't make much sense, does it?

@mjackson
Copy link
Member

@taurose Just a heads up: There was a lot of discussion in #94 that ultimately led to removing support for the <base> tag entirely. One less thing to worry about :)

@agundermann
Copy link
Contributor

@mjackson Thanks for letting me know. I had a feeling we were doing something wrong in this regard, but never found time to investigate. This makes a lot of sense.

@taion taion deleted the fix-replace-hash branch July 14, 2016 20:50
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants