Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix https://github.com/reactjs/react-router/issues/3241 #267

Merged
merged 2 commits into from
Apr 14, 2016
Merged

Attempt to fix https://github.com/reactjs/react-router/issues/3241 #267

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2950fca
Attempt to fix https://github.com/reactjs/react-router/issues/3241
slorber Apr 5, 2016
b0ca6be
When initializing history with initial state, do not provide path to …
slorber Apr 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/createBrowserHistory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function createBrowserHistory(options={}) {
key = history.createKey()

if (isSupported)
window.history.replaceState({ ...historyState, key }, null, path)
window.history.replaceState({ ...historyState, key }, null, window.location.href)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3rd arg here should just be omitted, e.g.

window.history.replaceState({ ...historyState, key }, null)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks yes I think it should work too, I'll try tomorow and edit my PR

}

const location = parsePath(path)
Expand Down