chore: upgrade jest and jsdom #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0f16b2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jenseng
force-pushed
the
upgrade-jest-and-jsdom
branch
3 times, most recently
from
7a768ac
to
730dbb2
Compare
MichaelDeBoey
approved these changes
May 5, 2023
This lets us remove a polyfill and some other hacks, and brings along some additional jsdom features which will facilitate testing fixes to submitter serialization. Note: * jsdom is making it harder to stub things, so we inject a jest-friendly window into the router. I'm not a huge fan of DI when used solely for the sake of testing, but this seems less terrible than other approaches (e.g. (patch-package-ing jsdom, or monkey-patching Object.defineProperty) 🙃 * We use a yarn resolution to get the latest jsdom, despite the latest jest pinning it at ^20.0.0. Per the maintainers, this is fine as jest doesn't need any code changes to work with new jsdom, and there are no concrete plans yet to ship a major version.
jenseng
force-pushed
the
upgrade-jest-and-jsdom
branch
from
730dbb2
to
e516138
Compare
|
👋 @brophdawg11 :) |
brophdawg11
approved these changes
May 25, 2023
|
Thanks for the ping @jenseng - I kept meaning to come back to this and then, well, didn't 😅 Let me know if the minor updates look ok to you and I'll get this merged. Agree on DI being better than the alternatives, and it also follows the pattern we use in |
brophdawg11
reviewed
May 25, 2023
|
Awesome, thanks @brophdawg11! |
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us remove a polyfill and some other hacks, and brings along some additional jsdom features which will facilitate testing fixes to submitter serialization (see #9865).
Note: