Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future.v7_startTransition flag #10596

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #10579 (second half)

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: 2eac9cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Minor
react-router-dom Minor
react-router-dom-v5-compat Minor
react-router-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +2 to +3
"react-router": minor
"react-router-dom": minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new future flag it'll be a new 6.13.0 minor release

@@ -49,12 +49,46 @@ The lifecycle is thus either:

## Current Future Flags

Here's the current future flags in React Router v6 today:
Here's the current future flags in React Router v6 today.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this feel confusing? Some flags are router-only and have nothing to do with rendering, others are render-only so I kept them split, but this does mean we export a FutureConfig from both @remix-run/router and react-router.

@brophdawg11
Copy link
Contributor Author

Move the feature detection stuff to it's own file

const START_TRANSITION = "startTransition";
const startTransitionImpl = React[START_TRANSITION];
export default startTransitionImpl || (cb) => cb();

packages/react-router-dom/index.tsx Outdated Show resolved Hide resolved
packages/react-router-dom/index.tsx Outdated Show resolved Hide resolved
packages/react-router-dom/index.tsx Outdated Show resolved Hide resolved
packages/react-router/lib/components.tsx Outdated Show resolved Hide resolved
packages/react-router/lib/components.tsx Outdated Show resolved Hide resolved
packages/react-router-dom/index.tsx Outdated Show resolved Hide resolved
packages/react-router-dom/index.tsx Outdated Show resolved Hide resolved
packages/react-router-dom/index.tsx Outdated Show resolved Hide resolved
@brophdawg11 brophdawg11 merged commit 5d9be06 into release-next Jun 13, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/v7-startTransition branch June 13, 2023 18:39
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.13.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.13.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants